Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace tap with node --test #73

Merged
merged 2 commits into from
May 6, 2024
Merged

replace tap with node --test #73

merged 2 commits into from
May 6, 2024

Conversation

msimerson
Copy link
Contributor

@msimerson msimerson commented May 4, 2024 •
edited
Loading

This PR requires a little more consideration. Factors:

  • it gets rid of a dependency
    • that requires semi-frequent updates
    • that adds 5100 lines to package-lock.json
  • the test output from node --test isn't as good as tap
  • node --test does not do automatic coverage testing
    • npm run cover will do it (script added)
  • coverage testing can also be done with a GitHub Action workflow
    • included in this PR

@msimerson msimerson force-pushed the tap2nodetest branch 2 times, most recently from d11b232 to aa4b537 Compare May 4, 2024 22:06
@msimerson msimerson marked this pull request as ready for review May 5, 2024 22:46
@jackbearheart
Copy link
Owner

Could use a rebase now.

@msimerson
Copy link
Contributor Author

done.

@jackbearheart
Copy link
Owner

Thanks. I think it re-deletes tests.xml.

@msimerson
Copy link
Contributor Author

Indeed. Fixed.

@jackbearheart jackbearheart merged commit 8e6be27 into jackbearheart:master May 6, 2024
14 checks passed
@msimerson msimerson deleted the tap2nodetest branch May 6, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msimerson @jackbearheart