Skip to content

Commit

Permalink
Merge pull request microsoft#165 from Microsoft/pullrequestreviewcomm…
Browse files Browse the repository at this point in the history
…entevent

Resolve TypeError: Cannot read property 'id' of null for PullRequestR…
Reviewed in person.
  • Loading branch information
geneh authored Jan 9, 2019
2 parents 4e0b3ab + 0c8cf3f commit 0602563
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion providers/fetcher/githubProcessor.js
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,11 @@ class GitHubProcessor {
request.queue('LegacyPullRequestReviewCommentEvent', request.document.payload.comment.pull_request_url, request.policy, context);
return null;
}
let [, repo, payload] = this._addEventBasics(request);
let [document, repo, payload] = this._addEventBasics(request);
// Sometimes payload.pull_request is null instead of an object.
if (!payload.pull_request) {
return document;
}
const qualifier = `urn:repo:${repo}:pull_request:${payload.pull_request.id}`;
if (payload.action === 'deleted') {
const context = { deletedAt: request.payload.fetchedAt };
Expand Down

0 comments on commit 0602563

Please sign in to comment.