fix: annotation layer crashes when clearing type select (apache#11787)

jaihind213 · Nov 24, 2020 · 872a54d · 872a54d
1 parent 25345be
commit 872a54d
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/superset-frontend/src/explore/components/controls/AnnotationLayer.jsx b/superset-frontend/src/explore/components/controls/AnnotationLayer.jsx
@@ -597,6 +597,7 @@ export default class AnnotationLayer extends React.PureComponent {
             { value: 'dotted', label: 'Dotted' },
           ]}
           value={style}
+          clearable={false}
           onChange={v => this.setState({ style: v })}
         />
         <SelectControl
@@ -704,6 +705,7 @@ export default class AnnotationLayer extends React.PureComponent {
                 description={t('Choose the Annotation Layer Type')}
                 label={t('Annotation Layer Type')}
                 name="annotation-layer-type"
+                clearable={false}
                 options={supportedAnnotationTypes}
                 value={annotationType}
                 onChange={this.handleAnnotationType}
@@ -740,6 +742,7 @@ export default class AnnotationLayer extends React.PureComponent {
 
             <Button
               buttonSize="sm"
+              buttonStyle="primary"
               disabled={!isValid}
               onClick={this.submitAnnotation}
             >