Close videojsGH-971: Quiet down deprecation warnings.

jailecoeu · Feb 7, 2014 · 3cb41c7 · 3cb41c7
1 parent 2d5ca1e
commit 3cb41c7
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/js/events.js b/src/js/events.js
@@ -179,8 +179,13 @@ vjs.fixEvent = function(event) {
     // TODO: Probably best to create a whitelist of event props
     for (var key in old) {
       // Safari 6.0.3 warns you if you try to copy deprecated layerX/Y
-      if (key !== 'layerX' && key !== 'layerY') {
-        event[key] = old[key];
+      // Chrome warns you if you try to copy deprecated keyboardEvent.keyLocation
+      if (key !== 'layerX' && key !== 'layerY' && key !== 'keyboardEvent.keyLocation') {
+        // Chrome 32+ warns if you try to copy deprecated returnValue, but
+        // we still want to if preventDefault isn't supported (IE8).
+        if (!(key == 'returnValue' && old.preventDefault)) {
+          event[key] = old[key];
+        }
       }
     }