Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #578 make produced META-INF/MANIFEST.MF reproducible #579

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

olamy
Copy link
Contributor

@olamy olamy commented Mar 12, 2024

Signed-off-by: Olivier Lamy [email protected]

@markt-asf
Copy link
Contributor

This doesn't fix the issue. It adds the correct entries after the incorrect entries.

@markt-asf
Copy link
Contributor

Having researched the header a little, I think we can just drop it. It isn't an OSGi standard header, it is BND specific and serves no useful purpose I can see.

@olamy
Copy link
Contributor Author

olamy commented Mar 14, 2024

oops my bad. I didn't check correctly.
Sorry for that.
I have removed completely the OSGI header.

@olamy olamy added the Build |Build/CI/CD pipelines related tasks. label Mar 14, 2024
@olamy olamy requested a review from markt-asf March 16, 2024 00:57
@olamy
Copy link
Contributor Author

olamy commented Mar 18, 2024

Nothing controversial here. So merging it.

@olamy olamy merged commit 39a9818 into jakartaee:master Mar 18, 2024
2 checks passed
@olamy olamy deleted the issue-578 branch March 18, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build |Build/CI/CD pipelines related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants