Gaussianmixture #288
Open
Gaussianmixture #288
+7
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklearn.mixture.gmm became GaussianMixture in scikit-learn 0.18. Some parameters have changed names. This commit updates notebook to work with these changes. Tested in both anaconda python and colab.
sklearn 0.18 deprecation, import make_blobs from sklearn.datasets directly. This fixes the "future" warning regarding the deprecation.
|
Hi @jakevdp, I think this PR will be helpful if merged. I recently encountered the problems resolved by this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows notebook to run on scikit-learn 0.18+. The calling convention has changed since that release, with name
GaussianMixtureinstead of oldGMM. Parametercovariances_instead ofcovars_,random_statecan only be assigned to model, not the sample, andsamplenow returns a tuple of which the 0th element is the desired array of samples. Also fixed a deprecation warning aboutmake_blobswhich is now to be imported directly fromsklearn.datasetsinstead of deprecatedsamples_generator. I've tested this on my Anaconda install (Python-3.8.5, scikit-learn-0.23.2) and on colab. (Thanks for producing this fantastic book and this demo!)