-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
7 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,18 +2,17 @@ Iron is Jane Street's internal code review tool. | |
|
||
For more on the design of iron, see the following blog posts: | ||
|
||
https://blog.janestreet.com/code-review-that-isnt-boring/ | ||
https://blog.janestreet.com/scrutinizing-your-code-in-style/ | ||
https://blog.janestreet.com/ironing-out-your-release-process/ | ||
https://blog.janestreet.com/putting-the-i-back-in-ide-towards-a-github-explorer/ | ||
- https://blog.janestreet.com/code-review-that-isnt-boring/ | ||
- https://blog.janestreet.com/scrutinizing-your-code-in-style/ | ||
- https://blog.janestreet.com/ironing-out-your-release-process/ | ||
- https://blog.janestreet.com/putting-the-i-back-in-ide-towards-a-github-explorer/ | ||
|
||
A key design decision was to review diffs rather than patches: | ||
|
||
https://blog.janestreet.com/designing-a-code-review-tool-part-2-patches-or-diffs/ | ||
https://blog.janestreet.com/patch-review-vs-diff-review-revisited/ | ||
- https://blog.janestreet.com/designing-a-code-review-tool-part-2-patches-or-diffs/ | ||
- https://blog.janestreet.com/patch-review-vs-diff-review-revisited/ | ||
|
||
We no longer release the code of iron, not because the code is proprietary | ||
but | ||
because one couldn't run the code elsewhere without first reproducing many | ||
but because one couldn't run the code elsewhere without first reproducing many | ||
trivial features of our internal environment. We're still happy to share or | ||
discuss the code, though: just email [email protected]. |