devlink: Unlock on error in dumpit()

This needs to unlock before returning. Fixes: 544e7c3 ("net: devlink: Add support for port regions") Signed-off-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/20201026080127.GB1628785@mwanda Signed-off-by: Jakub Kicinski <[email protected]>
jangid · Oct 28, 2020 · 0d8cb94 · 0d8cb94
1 parent 6c21180
commit 0d8cb94
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/net/core/devlink.c b/net/core/devlink.c
@@ -4919,8 +4919,10 @@ static int devlink_nl_cmd_region_read_dumpit(struct sk_buff *skb,
 		index = nla_get_u32(info->attrs[DEVLINK_ATTR_PORT_INDEX]);
 
 		port = devlink_port_get_by_index(devlink, index);
-		if (!port)
-			return -ENODEV;
+		if (!port) {
+			err = -ENODEV;
+			goto out_unlock;
+		}
 	}
 
 	region_name = nla_data(attrs[DEVLINK_ATTR_REGION_NAME]);