Skip to content

Commit

Permalink
net: ethernet: dnet: use phy_ethtool_{get|set}_link_ksettings
Browse files Browse the repository at this point in the history
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Philippe Reynes authored and davem330 committed Jun 28, 2016
1 parent 958974f commit 1ba44a1
Showing 1 changed file with 2 additions and 22 deletions.
24 changes: 2 additions & 22 deletions drivers/net/ethernet/dnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -730,26 +730,6 @@ static struct net_device_stats *dnet_get_stats(struct net_device *dev)
return nstat;
}

static int dnet_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
{
struct phy_device *phydev = dev->phydev;

if (!phydev)
return -ENODEV;

return phy_ethtool_gset(phydev, cmd);
}

static int dnet_set_settings(struct net_device *dev, struct ethtool_cmd *cmd)
{
struct phy_device *phydev = dev->phydev;

if (!phydev)
return -ENODEV;

return phy_ethtool_sset(phydev, cmd);
}

static int dnet_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
{
struct phy_device *phydev = dev->phydev;
Expand All @@ -772,11 +752,11 @@ static void dnet_get_drvinfo(struct net_device *dev,
}

static const struct ethtool_ops dnet_ethtool_ops = {
.get_settings = dnet_get_settings,
.set_settings = dnet_set_settings,
.get_drvinfo = dnet_get_drvinfo,
.get_link = ethtool_op_get_link,
.get_ts_info = ethtool_op_get_ts_info,
.get_link_ksettings = phy_ethtool_get_link_ksettings,
.set_link_ksettings = phy_ethtool_set_link_ksettings,
};

static const struct net_device_ops dnet_netdev_ops = {
Expand Down

0 comments on commit 1ba44a1

Please sign in to comment.