atomic_open(): be paranoid about may_open() return value

It should never return positives; however, with Linux S&M crowd involved, no bogosity is impossible. Results would be unpleasant... Signed-off-by: Al Viro <[email protected]>
jangid · May 2, 2016 · b3d58ea · b3d58ea
1 parent 0fb1ea0
commit b3d58ea
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/fs/namei.c b/fs/namei.c
@@ -2920,6 +2920,8 @@ static int atomic_open(struct nameidata *nd, struct dentry *dentry,
 		acc_mode = 0;
 	}
 	error = may_open(&file->f_path, acc_mode, open_flag);
+	if (WARN_ON(error > 0))
+		error = -EINVAL;
 out:
 	dput(dentry);
 	return error;