Skip to content

Commit

Permalink
xfs: fix scrub flagging rtinherit even if there is no rt device
Browse files Browse the repository at this point in the history
The kernel has always allowed directories to have the rtinherit flag
set, even if there is no rt device, so this check is wrong.

Fixes: 80e4e12 ("xfs: scrub inodes")
Signed-off-by: Darrick J. Wong <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
  • Loading branch information
djwong committed Nov 4, 2020
1 parent c2f0921 commit c1f6b1a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/xfs/scrub/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,7 @@ xchk_inode_flags(
goto bad;

/* rt flags require rt device */
if ((flags & (XFS_DIFLAG_REALTIME | XFS_DIFLAG_RTINHERIT)) &&
!mp->m_rtdev_targp)
if ((flags & XFS_DIFLAG_REALTIME) && !mp->m_rtdev_targp)
goto bad;

/* new rt bitmap flag only valid for rbmino */
Expand Down

0 comments on commit c1f6b1a

Please sign in to comment.