Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ts types #37

Merged
merged 1 commit into from
Sep 28, 2021
Merged

add ts types #37

merged 1 commit into from
Sep 28, 2021

Conversation

z81
Copy link
Contributor

@z81 z81 commented Sep 26, 2021

No description provided.

@z81 z81 force-pushed the ts-types branch 2 times, most recently from cff5353 to f901c9a Compare September 26, 2021 16:31
@jangxx
Copy link
Owner

jangxx commented Sep 27, 2021

Thanks for your contribution! Before I merge this, I have two questions however: does the file index.d.ts have to be both at the top level and in types/? Seems redundant to me to have the file two times, but I've not used typescript before, so I'm not sure.

Also, whenever I merged typescript contributions in other repos, they always included some entries in package.json as well. Again, I'm not sure what exactly is required here, but I think that you need to add those as well before I can merge this.

@z81
Copy link
Contributor Author

z81 commented Sep 27, 2021 •
edited
Loading

@jangxx Sorry, it's mistake, i removed types/index.d.ts.

@jangxx jangxx merged commit f2b4aff into jangxx:master Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z81 @jangxx