Not all Objects have a constructor property

Reviewed By: avp Differential Revision: D18284972 fbshipit-source-id: a3e65654df24a7b2197913c27516a128275962ef
janicduplessis · Nov 14, 2019 · d46809b · d46809b
1 parent 98737a8
commit d46809b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/test/repl/pretty.js b/test/repl/pretty.js
@@ -115,6 +115,9 @@ obj[Symbol('xyz')] = 5
 obj
 // CHECK-NEXT: { Symbol(abc): 3, Symbol(def): 4, Symbol(xyz): 5 }
 
+obj = Object.create(null)
+// CHECK-NEXT: {  }
+
 a = {}
 // CHECK-NEXT: { }
 Object.defineProperty(a, 'x', {

diff --git a/tools/repl/evaluate-line.js b/tools/repl/evaluate-line.js
@@ -188,7 +188,7 @@ C_STRING((function() {
         elements.push(prettyPrintProp(value, prop, visited));
       }
     }
-    if (value.constructor.name && value.constructor.name !== "Object") {
+    if (value.constructor && value.constructor.name && value.constructor.name !== "Object") {
       return value.constructor.name + ' { ' + elements.join(', ') + ' }';
     } else {
       return '{ ' + elements.join(', ') + ' }';