fix: compare validation now expects singular noun #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On pydantic-code >= 2.12, the validation error messages use the singular of the word "character" when the number 1 is specified in a condition. This breaks the engine.compare validation, which expected the plural. Refs: jaraco#204 Signed-off-by: Jaremy Hatler <[email protected]>
|
I tested this as part of jhatler#1 by running the tests in the main.yml workflow on my fork. |
|
Thanks for this. I stumbled onto the same issue and addressed it in 5ef0bab before I got to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On pydantic-code >= 2.12, the validation error messages use the singular of the word "character" when the number 1 is specified in a condition. This breaks the engine.compare validation, which expected the plural.
Refs: #204
Signed-off-by: Jaremy Hatler [email protected]