_plequal: marginally reduce cyclomatic complexity #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may or may not be an improvement; please feel free to close this if it does not seem valuable or more comprehensible than the existing code.
I was briefly puzzled by the seemingly-identical
if ...conditions that currently exist here (L2608-L2611) compared to here -- in fact my first suggestion for a PR here was going to be to remove the second pair of those as redundant, before I ran the test suite and encountered failures.However, in hindsight it's not all that difficult to infer that updating the instance dictionary attribute affects the logic of those functions (a little unusual perhaps because
plis a callable argument, not accessed viaselfto make it obviously an instance method, but it's still understandable).