Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(env/refactor): use eslintrc ignorePattern instead of CLI arg #546

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(env/refactor): use eslintrc ignorePattern instead of CLI arg #546

wants to merge 1 commit into from

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Mar 7, 2020 •
edited
Loading

just a change to internal linting

@agilgur5 agilgur5 added the scope: internal Changes only affect the internal API label Mar 9, 2020
@agilgur5
Copy link
Collaborator Author

agilgur5 commented Mar 9, 2020

Ah, I see the lint tests fail since they use the same .eslintrc 😅 😅 . Wonder if there's a way to do configure with .eslintrc without affecting the tests... 🤔

@agilgur5
Copy link
Collaborator Author

agilgur5 commented Oct 6, 2020

If we add a blank eslintrc into the lint folder that might fix it from looking up a directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: internal Changes only affect the internal API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agilgur5