Skip to content

Commit

Permalink
build: Change how we run the development server. The old way had a ra…
Browse files Browse the repository at this point in the history
…ce condition that would sometimes leave node listening on port 8000 after the server was killed. (googleads#652)
  • Loading branch information
shawnbuso authored Jun 12, 2018
1 parent 78026f3 commit 8dab561
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"scripts": {
"contBuild": "watch 'npm run rollup:max' src",
"predevServer": "echo \"Starting up server on localhost:8000.\"",
"devServer": "forever start ./node_modules/http-server/bin/http-server -p 8000 && npm run contBuild",
"postdevServer": "forever stop ./node_modules/http-server/bin/http-server",
"devServer": "npm-run-all -p testServer contBuild",
"lint": "eslint \"src/*.js\"",
"rollup": "npm-run-all rollup:*",
"rollup:max": "rollup -c configs/rollup.config.js",
Expand Down Expand Up @@ -55,7 +54,6 @@
"eslint": "^4.11.0",
"eslint-config-google": "^0.9.1",
"eslint-plugin-jsdoc": "^3.2.0",
"forever": "^0.15.3",
"geckodriver": "^1.10.0",
"http-server": "^0.10.0",
"mocha": "^4.0.1",
Expand Down

0 comments on commit 8dab561

Please sign in to comment.