bunch of warning fixes

javadeveloper001 · Jun 1, 2018 · d517b3c · d517b3c
1 parent 8ed1de5
commit d517b3c
Show file tree

Hide file tree

Showing 47 changed files with 775 additions and 556 deletions.
diff --git a/Cheat Engine/CEFuncProc.pas b/Cheat Engine/CEFuncProc.pas
@@ -2414,6 +2414,7 @@ function GetCEdir:string;
 function GetWinDir:string;
 var x: pchar;
 begin
+  result:='';
   getmem(x,200);
   if GetWindowsDirectory(x,200)>0 then
   begin
@@ -2929,11 +2930,14 @@ function VariableTypeToTranslatedString(variableType: TVariableType): string;
     vtPointer: result:=rs_vtPointer;
     vtAutoAssembler: Result:=rs_vtAutoAssembler;
     vtCustom: Result:=rs_vtCustom;
+    else
+     result:='Error';
   end;
 end;
 
 function VariableTypeToString(variableType: TVariableType): string;
 begin
+
   case variabletype of
     vtAll: result:='All';
     vtBinary: result:='Binary';
@@ -2949,6 +2953,8 @@ function VariableTypeToString(variableType: TVariableType): string;
     vtPointer: result:='Pointer';
     vtAutoAssembler: Result:='Auto Assembler Script';
     vtCustom: Result:='Custom';
+    else
+     result:='Error';
   end;
 end;
 

diff --git a/Cheat Engine/CustomTypeHandler.pas b/Cheat Engine/CustomTypeHandler.pas
@@ -847,7 +847,7 @@ function registerCustomTypeLua(L: PLua_State): integer; cdecl;
 function registerCustomTypeAutoAssembler(L: PLua_State): integer; cdecl;
 var
   parameters: integer;
-  typename: string;
+  typename: string='';
   bytecount: integer;
   script: string;
   ct: TCustomType;

diff --git a/Cheat Engine/FoundCodeUnit.pas b/Cheat Engine/FoundCodeUnit.pas
@@ -723,6 +723,9 @@ procedure TFoundCodedialog.moreinfo;
 
   d: TDisassembler;
 begin
+  if processhandler.is64bit then
+    firstchar:='R' else firstchar:='E';
+
   itemindex:=foundcodelist.ItemIndex;
   if itemindex<>-1 then
   begin
@@ -935,8 +938,7 @@ procedure TFoundCodedialog.moreinfo;
       else
       begin
 
-        if processhandler.is64bit then
-          firstchar:='R' else firstchar:='E';
+
 
         lblRAX.caption:=firstchar+'AX='+IntToHex(coderecord.context.{$ifdef cpu64}Rax{$else}Eax{$endif},8);
         lblRBX.caption:=firstchar+'BX='+IntToHex(coderecord.context.{$ifdef cpu64}Rbx{$else}Ebx{$endif},8);

diff --git a/Cheat Engine/HotKeys.pas b/Cheat Engine/HotKeys.pas
@@ -156,6 +156,7 @@ function THotkeyform.HotkeyActionToText(a: TMemrecHotkeyAction): string;
   Increase value with:
 
   }
+  result:='';
   if memrec.VarType=vtAutoAssembler then
   begin
     case a of

diff --git a/Cheat Engine/LuaClass.pas b/Cheat Engine/LuaClass.pas
@@ -77,7 +77,13 @@   TClasslistentry=record
 function TRecordEntries.getEntry(index: integer): TRecordEntry;
 begin
   if index<length(list) then
-    result:=list[index];
+    result:=list[index]
+  else
+  begin
+    result.name:='';
+    result.getf:=nil;
+    result.setf:=nil;
+  end;
 end;
 
 procedure TRecordEntries.setEntry(index: integer; e: TRecordEntry);

diff --git a/Cheat Engine/LuaHandler.pas b/Cheat Engine/LuaHandler.pas
@@ -4667,7 +4667,7 @@ function lua_dbvm_getNMIcount(L: PLua_state): integer; cdecl;
 
 function lua_dbvm_watch_writes(L: PLua_state): integer; cdecl;
 var
-  physicalAddress: qword;
+  physicalAddress: qword=0;
   size: integer;
   options: DWORD;
   MaxEntryCount: integer;
@@ -4704,7 +4704,7 @@ function lua_dbvm_watch_writes(L: PLua_state): integer; cdecl;
 
 function lua_dbvm_watch_reads(L: PLua_state): integer; cdecl;
 var
-  physicalAddress: qword;
+  physicalAddress: qword=0;
   size: integer;
   options: DWORD;
   MaxEntryCount: integer;
@@ -5132,6 +5132,8 @@ function lua_dbvm_watch_disable(L: PLua_State): integer; cdecl;
 
   id:=lua_tointeger(L,1);
   dbvm_watch_delete(id);
+
+  result:=0;
 end;
 
 function lua_dbvm_cloak_activate(L: PLua_State): integer; cdecl;
@@ -6703,7 +6705,7 @@ function createTreeView(L: Plua_State): integer; cdecl; //undocument, unsupporte
 
 function lua_loadTable(L: Plua_State): integer; cdecl;
 var
-  filename: string;
+  filename: string='';
   parameters: integer;
   merge: boolean;
   doc: TXMLDocument;
@@ -8668,6 +8670,7 @@ function lua_loadFontFromStream(L: PLua_state): integer; cdecl;
 
   h: THandle;
 begin
+  result:=0;
 
   if lua_isuserdata(L, 1) then
   begin
@@ -8679,12 +8682,7 @@ function lua_loadFontFromStream(L: PLua_state): integer; cdecl;
       lua_pushinteger(L, h);
       result:=1;
     end;
-
   end;
-
-
-
-
 end;
 
 function lua_speakex(engLang: boolean; L: Plua_State): integer; cdecl;
@@ -8696,7 +8694,10 @@ function lua_speakex(engLang: boolean; L: Plua_State): integer; cdecl;
   pc:=lua_gettop(L);
 
   if pc>=1 then
-    s:=Lua_ToString(L, 1);
+    s:=Lua_ToString(L, 1)
+  else
+    exit(0);
+
 
   if engLang then
   begin
@@ -9556,7 +9557,7 @@ function lua_getHandleList(L: PLua_state): integer; cdecl;
   i,j: integer;
 
   filter: integer;
-  peprocess: ptruint;
+  peprocess: ptruint=0;
 begin
   i:=sizeof(SYSTEM_HANDLE_TABLE_ENTRY_INFO)+128*sizeof(SYSTEM_HANDLE_TABLE_ENTRY_INFO);
   getmem(shi,i);
@@ -9710,9 +9711,11 @@ function lua_cpuid(L: PLua_state): integer; cdecl;
 var r: TCPUIDResult;
 i: integer;
 begin
-  if lua_gettop(L)=0 then exit(0);
   if lua_gettop(L)>=1 then
-    a:=lua_tointeger(L,1);
+    a:=lua_tointeger(L,1)
+  else
+    exit(0);
+
 
   if lua_gettop(L)>=2 then
     c:=lua_tointeger(L,2)

diff --git a/Cheat Engine/MainUnit2.pas b/Cheat Engine/MainUnit2.pas
@@ -24,7 +24,7 @@ procedure initcetitle;
 
 
 
-const beta='Beta 3'; //empty this for a release
+const beta='Beta 4'; //empty this for a release
 
 var
   CEnorm:string;

diff --git a/Cheat Engine/MemoryBrowserFormUnit.pas b/Cheat Engine/MemoryBrowserFormUnit.pas
@@ -2920,6 +2920,7 @@ procedure TMemoryBrowser.EAXLabelDblClick(Sender: TObject);
     labeltext: string;
 
 begin
+  regname:='';
   labeltext:=tlabel(sender).Caption;
 
   if (debuggerthread<>nil) and (debuggerthread.isWaitingToContinue) then
@@ -2955,6 +2956,7 @@ procedure TMemoryBrowser.EAXLabelDblClick(Sender: TObject);
         26: regname:='OF';
 
         6408..6415: regname:='R'+inttostr(i-6400);
+
       end;
 
 

diff --git a/Cheat Engine/MemoryRecordUnit.pas b/Cheat Engine/MemoryRecordUnit.pas
@@ -1539,29 +1539,29 @@ function TMemoryRecord.hasSelectedParent: boolean;
 procedure TMemoryRecord.getXMLNode(node: TDOMNode; selectedOnly: boolean);
 {$IFNDEF UNIX}
 var
-  doc: TDOMDocument;
-  cheatEntry: TDOMNode;
-  cheatEntries: TDOMNode;
-  offsets: TDOMNode;
+  doc: TDOMDocument=nil;
+  cheatEntry: TDOMNode=nil;
+  cheatEntries: TDOMNode=nil;
+  offsets: TDOMNode=nil;
   hks, hk,hkkc: TDOMNode;
-  opt: TDOMNode;
-  laststate: TDOMNode;
-  soundentry: TDOMNode;
+  opt: TDOMNode=nil;
+  laststate: TDOMNode=nil;
+  soundentry: TDOMNode=nil;
 
-  n: TDOMNode;
+  n: TDOMNode=nil;
 
-  tn: TTreenode;
+  tn: TTreenode=nil;
   i,j: integer;
   a:TDOMAttr;
 
   s: ansistring;
 
-  ddl: TDOMNode;
-  offset: TDOMNode;
+  ddl: TDOMNode=nil;
+  offset: TDOMNode=nil;
 {$ENDIF}
 begin
   {$IFNDEF UNIX}
- if selectedonly then
+  if selectedonly then
   begin
     if (not isselected) then exit; //don't add if not selected and only the selected items should be added
 
@@ -1682,8 +1682,7 @@ procedure TMemoryRecord.getXMLNode(node: TDOMNode; selectedOnly: boolean);
   end;
 
 
-
-  if Active then
+  if (laststate<>nil) and Active then
   begin
     a:=doc.CreateAttribute('Activated');
     a.TextContent:='1';
@@ -3169,6 +3168,7 @@ function TMemoryRecord.getlinkedDropDownMemrec_LoopDetected: boolean;
 
 function MemRecHotkeyActionToText(action: TMemrecHotkeyAction): string;
 begin
+  result:='';
   //DO NOT TRANSLATE THIS
   case action of
     mrhToggleActivation: result:='Toggle Activation';

diff --git a/Cheat Engine/StructuresFrm2.lfm b/Cheat Engine/StructuresFrm2.lfm
@@ -1,7 +1,7 @@
 object frmStructures2: TfrmStructures2
-  Left = 274
+  Left = 263
   Height = 381
-  Top = 595
+  Top = 706
   Width = 542
   Caption = 'Structure dissect'
   ClientHeight = 361

diff --git a/Cheat Engine/StructuresFrm2.pas b/Cheat Engine/StructuresFrm2.pas
@@ -787,6 +787,7 @@ function lookupStructureName(address: ptruint; defaultName: string) : string;
 
 function DisplaymethodToString(d:TdisplayMethod): string;
 begin
+  result:='';
   case d of
     dtUnsignedInteger: result:=rsUnsignedInteger;
     dtSignedInteger: result:=rsSignedInteger;
@@ -4624,7 +4625,10 @@ procedure TfrmSTructures2.OnChangeTypeMenuItemClick(Sender: TObject);
   else if (Sender = miChangeTypeString) then vt := vtString
   else if (Sender = miChangeTypeUnicode) then vt := vtUnicodeString
   else if (Sender = miChangeTypeArrayOfByte) then vt := vtByteArray
-  else if (Sender = miChangeTypePointer) then vt := vtPointer;
+  else if (Sender = miChangeTypePointer) then vt := vtPointer
+  else
+    vt:=vtByte;
+
 
   case vt of
     vtByte: size := 1;
@@ -4637,6 +4641,8 @@ procedure TfrmSTructures2.OnChangeTypeMenuItemClick(Sender: TObject);
     vtByteArray: size := 16;
     vtString: size := 32;
     vtUnicodeString: size := 32;
+    else
+      size:=1;
   end;
 
   displayMethod := dtHexadecimal;

diff --git a/Cheat Engine/asktorunluascript.pas b/Cheat Engine/asktorunluascript.pas
@@ -43,6 +43,8 @@ implementation
 
 function TfrmLuaScriptQuestion.getLuaScriptAction: integer;
 begin
+  result:=0;
+
   if rbAlways.checked then result:=0 else
   if rbSignedOnly.checked then result:=1 else
   if rbAlwaysAsk.checked then result:=2 else
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,7 @@ procedure initcetitle; @@
-    const beta='Beta 3'; //empty this for a release
+    const beta='Beta 4'; //empty this for a release
     var
       CEnorm:string;
@@ Expand Down @@