spec: fix sel failures [chrome build]

refs failed specs: spec/selenium/calendar/calendar2_new_scheduler_teacher_spec.rb:40 spec/selenium/collaborations_form_teacher_spec.rb:63 spec/selenium/quizzes/quizzes_log_auditing_spec.rb:80 Change-Id: I7d547833bd57f4663c35ad18b9c5878320f6ce55 Reviewed-on: https://gerrit.instructure.com/99673 Tested-by: Jenkins Reviewed-by: Pedro Fajardo <[email protected]> Product-Review: August Thornton <[email protected]> QA-Review: August Thornton <[email protected]>
javierjeronimo · Jan 16, 2017 · 139d2c9 · 139d2c9
1 parent 0126d90
commit 139d2c9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/spec/selenium/calendar/calendar2_new_scheduler_teacher_spec.rb b/spec/selenium/calendar/calendar2_new_scheduler_teacher_spec.rb
@@ -66,11 +66,12 @@
           set_value(fj('.time_field.end_time:visible'),end_time_text)
           set_value(fj('.date_field:visible'), date)
           find('.scheduler-event-details-footer .btn-primary').click
+          wait_for_ajax_requests
         end
 
         # make sure that the DB record for the Appointment Group is correct
         last_group = AppointmentGroup.last
-        expect(last_group.title).to eq title # spec breaks here
+        expect(last_group.title).to eq title
         expect(last_group.location_name).to eq location
         expect(last_group.start_at.strftime("%I")).to eq start_time_text
         expect(last_group.end_at.strftime("%I")).to eq end_time_text

diff --git a/spec/selenium/helpers/collaborations_specs_common.rb b/spec/selenium/helpers/collaborations_specs_common.rb
@@ -85,11 +85,10 @@ def select_from_all_course_groups(type, title)
     move_to_click("label[for=groups-filter-btn-#{@collaboration.id}]")
     wait_for_ajaximations
 
-    groups = ffj('.available-groups:visible a')
-    expect(groups.count).to eq 1
-    groups.first.click
+    expect(ffj("ul[aria-label='Available groups']:visible a")).to have_size 1
+    fj("ul[aria-label='Available groups']:visible").click
     wait_for_ajaximations
-    expect(ff('.members-list li')).to have_size(2)
+    expect(ff('.members-list li')).to have_size 2
     expect_new_page_load do
       submit_form('.edit_collaboration')
     end

diff --git a/spec/selenium/helpers/quizzes_common.rb b/spec/selenium/helpers/quizzes_common.rb
@@ -369,7 +369,9 @@ def wait_for_quiz_to_begin
   end
 
   def submit_quiz
-    expect_new_page_load(true) { f('#submit_quiz_button').click }
+    f('#submit_quiz_button').click
+    accept_alert if alert_present?
+    wait_for_ajax_requests
 
     expect(f('.quiz-submission .quiz_score .score_value')).to be_truthy
   end