Skip to content

Commit

Permalink
spec: fix fragile conversations specs
Browse files Browse the repository at this point in the history
Test Plan:
- Pass Jenkins / Chrome
- Code Review

Change-Id: I5bbdb408c374ea0c6dc3b033df956a2726f1a80a
Reviewed-on: https://gerrit.instructure.com/108245
Tested-by: Jenkins
Reviewed-by: Jahnavi Yetukuri <[email protected]>
Reviewed-by: KC Naegle <[email protected]>
Product-Review: Matt Fairbourn <[email protected]>
QA-Review: Matt Fairbourn <[email protected]>
  • Loading branch information
mfairbourn committed Apr 11, 2017
1 parent 45231f5 commit c9a137b
Showing 1 changed file with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
describe "message sending" do
it "should show error messages when no recipient is entered", priority: "1", test_id: 351236 do
get '/conversations'
f('.icon-compose').click
move_to_click('.icon-compose')
click_send
errors = ff('.error_text')
expect(errors[2].text).to include('Invalid recipient name.')
Expand Down Expand Up @@ -156,7 +156,7 @@
@course.save!

get '/conversations'
f('.icon-compose').click
move_to_click('.icon-compose')
expect(fj("#compose-message-course option:contains('#{@course.name}')")).to be
end

Expand All @@ -166,7 +166,7 @@
@course.save!

get '/conversations'
f('.icon-compose').click
move_to_click('.icon-compose')
expect(f("#compose-message-course")).not_to contain_jqcss("option:contains('#{@course.name}')")
end

Expand All @@ -176,7 +176,7 @@
@course.save!

get '/conversations'
f('.icon-compose').click
move_to_click('.icon-compose')
expect(f("#compose-message-course")).not_to contain_jqcss("option:contains('#{@course.name}')")
end
end
Expand Down Expand Up @@ -322,7 +322,7 @@ def assert_categories(container)
def goto_compose_modal
fln('Inbox').click
wait_for_ajaximations
f('.icon-compose').click
move_to_click('.icon-compose')
wait_for_ajaximations
f("#compose-new-message")
end
Expand Down

0 comments on commit c9a137b

Please sign in to comment.