Skip to content

Commit

Permalink
use role_id instead of role in roster editing dialogs
Browse files Browse the repository at this point in the history
test plan:
* through the course roster, the "Edit Sections" dialog
 for someone with a custom course role should work as before
* the "Link to Students" dialog should work as well for
 observers with custom observer roles

closes #CNVS-26032

Change-Id: I9709db9a0266366223fb0500f111f159a54765e1
Reviewed-on: https://gerrit.instructure.com/69929
Tested-by: Jenkins
Reviewed-by: Jeremy Stanley <[email protected]>
QA-Review: Jahnavi Yetukuri <[email protected]>
Product-Review: James Williams  <[email protected]>
  • Loading branch information
maneframe authored and roor0 committed Jan 14, 2016
1 parent 165777a commit c15b96e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ define [
type: enrollment.type
limit_privileges_to_course_section: enrollment.limit_privileges_to_course_section
if enrollment.role != enrollment.type
data.enrollment.role = enrollment.role
data.enrollment.role_id = enrollment.role_id
deferreds.push $.ajaxJSON url, 'POST', data, (newEnrollment) =>
_.extend newEnrollment, { can_be_removed: true }
newEnrollments.push newEnrollment
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ define [
type: enrollment.type
limit_privileges_to_course_section: enrollment.limit_priveleges_to_course_section
if enrollment.role != enrollment.type
data.enrollment.role = enrollment.role
data.enrollment.role_id = enrollment.role_id
udfds.push $.ajaxJSON url, 'POST', data, (newEnrollment) =>
newEnrollment.observed_user = user
newEnrollments.push newEnrollment
Expand Down

0 comments on commit c15b96e

Please sign in to comment.