Skip to content

Commit

Permalink
Skip flaky pytest timeout failure ITs.
Browse files Browse the repository at this point in the history
The `test_pytest_run_timeout_cant_terminate` test is causing the
pantsbuild-osx/pants Travis-CI job to go red roughly 50% of the time.
Local testing of this skip application found
`test_pytest_run_timeout_fails` also failing intermittently on my
machine so a skip is applied to that similarly fragile test as well.

Testing Done:
Ran the following locally and confirmed 2 skips:
```
./pants test \
  tests/python/pants_test/backend/python/tasks/:pytest_run_integration
```

Before the skips, I was able to get failure in one or both of the
skipped tests >50% of the time (linux box).

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/125117190

Bugs closed: 3255, 3258

Reviewed at https://rbcommons.com/s/twitter/r/3748/
  • Loading branch information
jsirois committed Apr 22, 2016
1 parent d44febc commit 3db4cce
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import os
import time
import unittest

from pants.util.contextutil import temporary_dir
from pants_test.pants_run_integration_test import PantsRunIntegrationTest
Expand All @@ -21,6 +22,7 @@ def test_pytest_run_timeout_succeeds(self):
'testprojects/tests/python/pants/timeout:exceeds_timeout'])
self.assert_success(pants_run)

@unittest.skip('https://github.com/pantsbuild/pants/issues/3255')
def test_pytest_run_timeout_fails(self):
start = time.time()
pants_run = self.run_pants(['clean-all',
Expand All @@ -41,6 +43,7 @@ def test_pytest_run_timeout_fails(self):
# Ensure that the timeout message triggered.
self.assertIn("FAILURE: Timeout of 1 seconds reached", pants_run.stdout_data)

@unittest.skip('https://github.com/pantsbuild/pants/issues/3255')
def test_pytest_run_timeout_cant_terminate(self):
start = time.time()
terminate_wait = 2
Expand Down

0 comments on commit 3db4cce

Please sign in to comment.