Skip to content

Commit

Permalink
Add transitive dep required by javac 8.
Browse files Browse the repository at this point in the history
Testing Done:
Before the fix:
```
JAVA_HOME=/usr/lib/jvm/java-8-openjdk \
  ./pants clean-all compile examples/src/java/org/pantsbuild/example/make_it_rain
...
                   [3/3] Compiling 1 zinc source in 1 target (examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain).
15:26:03 00:04       [compile]

15:26:03 00:04         [zinc]
                       [info] Compiling 1 Java source to /home/jsirois/dev/pantsbuild/jsirois-pants/.pants.d/compile/zinc/252d64521cf9/examples.src.java.org.pantsbuild.example.make_it_rain.make_it_rain/current/classes...
                       [warn] bootstrap class path not set in conjunction with -source 1.6
                       [error] /home/jsirois/dev/pantsbuild/jsirois-pants/examples/src/java/org/pantsbuild/example/make_it_rain/MakeItRain.java:14: cannot access org.apache.thrift.TBase
                       [error]   class file for org.apache.thrift.TBase not found
                       [error]     Distance notMuch = new Distance().setNumber(8).setUnit("mm");
                       [error] Compile failed at May 2, 2016 3:26:03 PM [0.024s]

                   compile(examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain) failed: Zinc compile failed.
FAILURE: Compilation failure: Failed jobs: compile(examples/src/java/org/pantsbuild/example/make_it_rain:make_it_rain)

15:26:03 00:04   [complete]
               FAILURE
```

Now green.

CI went green here:
  https://travis-ci.org/pantsbuild/pants/builds/127344136

Bugs closed: 3321

Reviewed at https://rbcommons.com/s/twitter/r/3808/
  • Loading branch information
jsirois committed May 2, 2016
1 parent 281df88 commit 477618c
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
java_library(name='make_it_rain',
sources=['MakeItRain.java',],
dependencies=[
'3rdparty:thrift-0.9.2',
'examples/src/thrift/org/pantsbuild/example/distance:distance-java',
'examples/src/thrift/org/pantsbuild/example/precipitation:precipitation-java',
],
Expand Down

0 comments on commit 477618c

Please sign in to comment.