Skip to content

Commit

Permalink
[Mosaic] Remove TODOs that are already addressed or obsolete.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 708045439
  • Loading branch information
WindQAQ authored and Google-ML-Automation committed Dec 19, 2024
1 parent 6b096b0 commit 77f3c11
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions jaxlib/mosaic/dialect/tpu/transforms/apply_vector_layout.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2092,8 +2092,6 @@ LogicalResult tpu_matmul_rule(RewriteContext &ctx, Operation &op,
maskVregs(rhs_vregs, padded_rhs_rows - rhs_shape[0], 0);
}

// TODO(b/328094640): use latch 3 for short dimensions.
// TODO(b/328093587): Skip zeros vreg matmul
// At this point, all paddings on vregs are masked out. For now, we
// append zero vregs to make LHS's second dim, both RHS's dims and ACC's
// second dim to be a multiple of mxu_size.
Expand Down

0 comments on commit 77f3c11

Please sign in to comment.