fix: selection menu respects current node direction (AppFlowy-IO#360)

modified insertNodeAfterSelection to copy current node text direction to the node which is going to get inserteded. resolves AppFlowy-IO#331
jazima · Aug 8, 2023 · 2ab0074 · 2ab0074
1 parent de02b96
commit 2ab0074
Show file tree

Hide file tree

Showing 2 changed files with 121 additions and 0 deletions.
diff --git a/lib/src/service/default_text_operations/format_rich_text_style.dart b/lib/src/service/default_text_operations/format_rich_text_style.dart
@@ -48,6 +48,11 @@ bool insertNodeAfterSelection(
   if (currentNode == null) {
     return false;
   }
+  node.updateAttributes({
+    blockComponentTextDirection:
+        currentNode.attributes[blockComponentTextDirection]
+  });
+
   final transaction = editorState.transaction;
   final delta = currentNode.delta;
   if (delta != null && delta.isEmpty) {

diff --git a/test/service/format_rich_text_style_test.dart b/test/service/format_rich_text_style_test.dart
@@ -0,0 +1,116 @@
+import 'package:appflowy_editor/appflowy_editor.dart';
+import 'package:appflowy_editor/src/service/default_text_operations/format_rich_text_style.dart';
+import 'package:flutter_test/flutter_test.dart';
+import '../new/infra/testable_editor.dart';
+
+void main() async {
+  setUpAll(() {
+    TestWidgetsFlutterBinding.ensureInitialized();
+  });
+
+  group('format rich text style', () {
+    testWidgets('insertNodeAfterSelection', (tester) async {
+      final editor = tester.editor..addParagraph();
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      expect(inserted, true);
+      final node = editor.nodeAtPath([1])!;
+      expect(node.attributes[blockComponentTextDirection], null);
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertNodeAfterSelection on empty node', (tester) async {
+      final editor = tester.editor..addNode(paragraphNode());
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      expect(inserted, true);
+      final node = editor.nodeAtPath([0])!;
+      expect(node.attributes[blockComponentTextDirection], null);
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertNodeAfterSelection on node with text direction',
+        (tester) async {
+      final editor = tester.editor
+        ..addNode(
+          paragraphNode(
+            text: ' ',
+            textDirection: blockComponentTextDirectionAuto,
+          ),
+        );
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      final node = editor.nodeAtPath([1])!;
+      expect(inserted, true);
+      expect(
+        node.attributes[blockComponentTextDirection],
+        blockComponentTextDirectionAuto,
+      );
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertNodeAfterSelection on empty node with text direction',
+        (tester) async {
+      final editor = tester.editor
+        ..addNode(
+          paragraphNode(textDirection: blockComponentTextDirectionLTR),
+        );
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      final inserted =
+          insertNodeAfterSelection(editor.editorState, paragraphNode());
+      await tester.pumpAndSettle();
+
+      final node = editor.nodeAtPath([0])!;
+      expect(inserted, true);
+      expect(
+        node.attributes[blockComponentTextDirection],
+        blockComponentTextDirectionLTR,
+      );
+
+      await editor.dispose();
+    });
+
+    testWidgets('insertHeadingAfterSelection on rtl node', (tester) async {
+      final editor = tester.editor
+        ..addNode(
+          paragraphNode(
+            text: ' ',
+            textDirection: blockComponentTextDirectionRTL,
+          ),
+        );
+      await editor.startTesting();
+
+      await editor.updateSelection(Selection.collapse([0], 0));
+      insertHeadingAfterSelection(editor.editorState, 1);
+      await tester.pumpAndSettle();
+
+      final node = editor.nodeAtPath([1])!;
+      expect(
+        node.attributes[blockComponentTextDirection],
+        blockComponentTextDirectionRTL,
+      );
+
+      await editor.dispose();
+    });
+  });
+}