fix: table padding and selection (AppFlowy-IO#432)

* fix: table padding when it gets scrolled The handler was getting out of region when table width was wider than editor size. * fix: modify scroll view padding
jazima · Sep 1, 2023 · 9143c1f · 9143c1f
1 parent f205f80
commit 9143c1f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/lib/src/editor/block_component/table_block_component/table_block_component.dart b/lib/src/editor/block_component/table_block_component/table_block_component.dart
@@ -144,6 +144,7 @@ class _TableBlockComponentWidgetState extends State<TableBlockComponentWidget>
     Widget child = Scrollbar(
       controller: _scrollController,
       child: SingleChildScrollView(
+        padding: const EdgeInsets.only(top: 10, left: 10, bottom: 4),
         controller: _scrollController,
         scrollDirection: Axis.horizontal,
         child: TableView(

diff --git a/lib/src/editor/block_component/table_block_component/table_cell_block_component.dart b/lib/src/editor/block_component/table_block_component/table_cell_block_component.dart
@@ -118,7 +118,7 @@ class _TableCeBlockWidgetState extends State<TableCelBlockWidget> {
           position: widget.node.attributes[TableCellBlockKeys.rowPosition],
           transform: context.select((Node n) {
             final int col = n.attributes[TableCellBlockKeys.colPosition];
-            double left = -15.0;
+            double left = -12;
             for (var i = 0; i < col; i++) {
               left -= getCellNode(n.parent!, i, 0)
                   ?.attributes[TableCellBlockKeys.width] as double;

diff --git a/lib/src/editor/block_component/table_block_component/table_col.dart b/lib/src/editor/block_component/table_block_component/table_col.dart
@@ -67,7 +67,7 @@ class _TableColState extends State<TableCol> {
               node: widget.tableNode.node,
               editorState: widget.editorState,
               position: widget.colIdx,
-              transform: Matrix4.translationValues(0.0, -15.0, 0.0),
+              transform: Matrix4.translationValues(0.0, -12, 0.0),
               alignment: Alignment.topCenter,
               menuBuilder: widget.menuBuilder,
               dir: TableDirection.col,