KNL-1538 RemoteHostFilter turn off allowed logging by default (sakaip…

…roject#4688)
jbbadano · Aug 17, 2017 · 3a29fd0 · 3a29fd0
1 parent 7d208f9
commit 3a29fd0
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/kernel/kernel-util/src/main/java/org/sakaiproject/util/RemoteHostFilter.java b/kernel/kernel-util/src/main/java/org/sakaiproject/util/RemoteHostFilter.java
@@ -90,7 +90,7 @@ public class RemoteHostFilter implements Filter {
 
     // Should allowed requests be logged
     @Setter
-    private boolean logAllowed = true;
+    private boolean logAllowed = false;
 
     // Should denied requests be logged
     @Setter

diff --git a/kernel/kernel-util/src/test/java/org/sakaiproject/util/RemoteHostFilterTest.java b/kernel/kernel-util/src/test/java/org/sakaiproject/util/RemoteHostFilterTest.java
@@ -47,9 +47,6 @@ public void setup() {
         request = new MockHttpServletRequest();
         response = new MockHttpServletResponse();
 
-        Mockito.when(serverConfigurationService.getBoolean("webservices.log-allowed", true)).thenReturn(true);
-        Mockito.when(serverConfigurationService.getBoolean("webservices.log-denied", true)).thenReturn(true);
-
         filter = new RemoteHostFilter();
         filter.setServerConfigurationService(serverConfigurationService);
     }

diff --git a/webservices/cxf/src/resources/applicationContext.xml b/webservices/cxf/src/resources/applicationContext.xml
@@ -37,7 +37,7 @@
                 <value>x\.x\.x\.x</value>
             </list>
         </property -->
-        <property name="logAllowed" value="true"/>
+        <property name="logAllowed" value="false"/>
         <property name="logDenied" value="true"/>
     </bean>