Skip to content

Commit

Permalink
Merge pull request freqtrade#10860 from xzmeng/fix-test-download-data…
Browse files Browse the repository at this point in the history
…-timerange

tests: fix failure when local timezone is not utc
  • Loading branch information
xmatthias authored Nov 1, 2024
2 parents 3da9f6d + 878adfb commit dafabd5
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions tests/commands/test_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
from freqtrade.exceptions import OperationalException
from freqtrade.persistence.models import init_db
from freqtrade.persistence.pairlock_middleware import PairLocks
from freqtrade.util import dt_floor_day, dt_now, dt_utc
from freqtrade.util import dt_utc
from tests.conftest import (
CURRENT_TEST_STRATEGY,
EXMS,
Expand Down Expand Up @@ -757,7 +757,13 @@ def test_download_data_keyboardInterrupt(mocker, markets):
assert dl_mock.call_count == 1


def test_download_data_timerange(mocker, markets):
@pytest.mark.parametrize("time", ["00:00", "00:03", "00:30", "23:56"])
@pytest.mark.parametrize(
"tzoffset",
["00:00", "+01:00", "-01:00", "+05:00", "-05:00"],
)
def test_download_data_timerange(mocker, markets, time_machine, time, tzoffset):
time_machine.move_to(f"2024-11-01 {time}:00 {tzoffset}")
dl_mock = mocker.patch(
"freqtrade.data.history.history_utils.refresh_backtest_ohlcv_data",
MagicMock(return_value=["ETH/BTC", "XRP/BTC"]),
Expand Down Expand Up @@ -797,8 +803,9 @@ def test_download_data_timerange(mocker, markets):
start_download_data(pargs)
assert dl_mock.call_count == 1
# 20days ago
days_ago = dt_floor_day(dt_now() - timedelta(days=20)).timestamp()
assert dl_mock.call_args_list[0][1]["timerange"].startts == days_ago
days_ago = datetime.now() - timedelta(days=20)
days_ago = dt_utc(days_ago.year, days_ago.month, days_ago.day)
assert dl_mock.call_args_list[0][1]["timerange"].startts == days_ago.timestamp()

dl_mock.reset_mock()
args = [
Expand Down

0 comments on commit dafabd5

Please sign in to comment.