Skip to content

Commit

Permalink
fs/afs/callback: Remove deprecated create_singlethread_workqueue
Browse files Browse the repository at this point in the history
The workqueue "afs_callback_update_worker" queues multiple work items
viz  &vnode->cb_broken_work, &server->cb_break_work which require strict
execution ordering. Hence, an ordered dedicated workqueue has been used.

Since the workqueue is being used on a memory reclaim path, WQ_MEM_RECLAIM
has been set to ensure forward progress under memory pressure.

Signed-off-by: Bhaktipriya Shridhar <[email protected]>
Signed-off-by: David Howells <[email protected]>
  • Loading branch information
bhaktipriya authored and dhowells committed Sep 4, 2016
1 parent 69ad052 commit 4c136da
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/afs/callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,8 @@ static void afs_callback_updater(struct work_struct *work)
*/
int __init afs_callback_update_init(void)
{
afs_callback_update_worker =
create_singlethread_workqueue("kafs_callbackd");
afs_callback_update_worker = alloc_ordered_workqueue("kafs_callbackd",
WQ_MEM_RECLAIM);
return afs_callback_update_worker ? 0 : -ENOMEM;
}

Expand Down

0 comments on commit 4c136da

Please sign in to comment.