Skip to content

Commit

Permalink
drm/modes: parse_cmdline: Remove some unnecessary code (v2)
Browse files Browse the repository at this point in the history
fb_get_options() will return fb_mode_option if no video=<connector-name>
argument is present on the kernel commandline, so there is no need to also
do this in drm_mode_parse_command_line_for_connector() as our only caller
uses fb_get_options() to get the mode_option argument.

Changes in v2:
-Split out the changes dealing with the initialization of the mode struct
 into a separate patch

Acked-by: Maxime Ripard <[email protected]>
Signed-off-by: Hans de Goede <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
  • Loading branch information
jwrdegoede committed Dec 16, 2019
1 parent 4e7a4a6 commit 5b92661
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/gpu/drm/drm_modes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1747,11 +1747,6 @@ bool drm_mode_parse_command_line_for_connector(const char *mode_option,

mode->panel_orientation = DRM_MODE_PANEL_ORIENTATION_UNKNOWN;

#ifdef CONFIG_FB
if (!mode_option)
mode_option = fb_mode_option;
#endif

if (!mode_option) {
mode->specified = false;
return false;
Expand Down

0 comments on commit 5b92661

Please sign in to comment.