Skip to content

Commit

Permalink
net: fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c
Browse files Browse the repository at this point in the history
commit 46e5da4 (net: qdisc: use rcu prefix and silence
 sparse warnings) triggers a spurious warning:

net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage!

The code should be using the _bh variant of rcu_dereference.

Signed-off-by: Valdis Kletnieks <[email protected]>
Acked-by: Eric Dumazet <[email protected]>
Acked-by: John Fastabend <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
valdisk authored and davem330 committed Dec 10, 2014
1 parent 11d3d2a commit 69204cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/sched/sch_fq_codel.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ static unsigned int fq_codel_classify(struct sk_buff *skb, struct Qdisc *sch,
TC_H_MIN(skb->priority) <= q->flows_cnt)
return TC_H_MIN(skb->priority);

filter = rcu_dereference(q->filter_list);
filter = rcu_dereference_bh(q->filter_list);
if (!filter)
return fq_codel_hash(q, skb) + 1;

Expand Down

0 comments on commit 69204cf

Please sign in to comment.