Skip to content

Commit

Permalink
dm integrity: introduce a function add_new_range_and_wait()
Browse files Browse the repository at this point in the history
Introduce a function add_new_range_and_wait() in order to avoid
repetitive code.  It will be used in the following commit.

Signed-off-by: Mikulas Patocka <[email protected]>
Signed-off-by: Mike Snitzer <[email protected]>
  • Loading branch information
Mikulas Patocka authored and snitm committed May 8, 2019
1 parent 4f43446 commit 8b3bbd4
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions drivers/md/dm-integrity.c
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,12 @@ static void wait_and_add_new_range(struct dm_integrity_c *ic, struct dm_integrit
} while (unlikely(new_range->waiting));
}

static void add_new_range_and_wait(struct dm_integrity_c *ic, struct dm_integrity_range *new_range)
{
if (unlikely(!add_new_range(ic, new_range, true)))
wait_and_add_new_range(ic, new_range);
}

static void init_journal_node(struct journal_node *node)
{
RB_CLEAR_NODE(&node->node);
Expand Down Expand Up @@ -1995,8 +2001,7 @@ static void do_journal_write(struct dm_integrity_c *ic, unsigned write_start,
io->range.n_sectors = (k - j) << ic->sb->log2_sectors_per_block;

spin_lock_irq(&ic->endio_wait.lock);
if (unlikely(!add_new_range(ic, &io->range, true)))
wait_and_add_new_range(ic, &io->range);
add_new_range_and_wait(ic, &io->range);

if (likely(!from_replay)) {
struct journal_node *section_node = &ic->journal_tree[i * ic->journal_section_entries];
Expand Down Expand Up @@ -2155,8 +2160,7 @@ static void integrity_recalc(struct work_struct *w)
if (!ic->meta_dev)
range.n_sectors = min(range.n_sectors, ((sector_t)1U << ic->sb->log2_interleave_sectors) - (unsigned)offset);

if (unlikely(!add_new_range(ic, &range, true)))
wait_and_add_new_range(ic, &range);
add_new_range_and_wait(ic, &range);

spin_unlock_irq(&ic->endio_wait.lock);

Expand Down

0 comments on commit 8b3bbd4

Please sign in to comment.