Skip to content

Commit

Permalink
arm64: dts: rockchip: Fix multiple thermal zones conflict in rk3399.dtsi
Browse files Browse the repository at this point in the history
Currently the common thermal zones definitions for the rk3399 assumes
multiple thermal zones are supported by the governors. This is not the
case and each thermal zone has its own governor instance acting
individually without collaboration with other governors.

As the cooling device for the CPU and the GPU thermal zones is the
same, each governors take different decisions for the same cooling
device leading to conflicting instructions and an erratic behavior.

As the cooling-maps is about to become an optional property, let's
remove the cpu cooling device map from the GPU thermal zone.

Signed-off-by: Daniel Lezcano <[email protected]>
Signed-off-by: Heiko Stuebner <[email protected]>
  • Loading branch information
dlezcano authored and mmind committed Jun 26, 2019
1 parent 587b4ee commit 95f231f
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions arch/arm64/boot/dts/rockchip/rk3399.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -821,15 +821,6 @@
type = "critical";
};
};

cooling-maps {
map0 {
trip = <&gpu_alert0>;
cooling-device =
<&cpu_b0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
<&cpu_b1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
};
};
};
};

Expand Down

0 comments on commit 95f231f

Please sign in to comment.