Skip to content

Commit

Permalink
char: mxser, fix ISA board lookup
Browse files Browse the repository at this point in the history
There's a bug in the mxser kernel module that still appears in the
2.6.29.4 kernel.

mxser_get_ISA_conf takes a ioaddress as its first argument, by passing the
not of the ioaddr, you're effectively passing 0 which means it won't be
able to talk to an ISA card.  I have tested this, and removing the !
fixes the problem.

Cc: "Peter Botha" <[email protected]>
Signed-off-by: Jiri Slaby <[email protected]>
Acked-by: Alan Cox <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Peter Botha authored and torvalds committed Jun 10, 2009
1 parent a61d90d commit 96050df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/char/mxser.c
Original file line number Diff line number Diff line change
Expand Up @@ -2711,7 +2711,7 @@ static int __init mxser_module_init(void)
continue;

brd = &mxser_boards[m];
retval = mxser_get_ISA_conf(!ioaddr[b], brd);
retval = mxser_get_ISA_conf(ioaddr[b], brd);
if (retval <= 0) {
brd->info = NULL;
continue;
Expand Down

0 comments on commit 96050df

Please sign in to comment.