Skip to content

Commit

Permalink
[PATCH] blktrace: don't return blktrace_seq from trace_note()
Browse files Browse the repository at this point in the history
Only the process notifier needs it, and it can set it manually.

Signed-off-by: Jens Axboe <[email protected]>
  • Loading branch information
Jens Axboe committed Dec 4, 2006
1 parent d3d9d2a commit a863055
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions block/blktrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ static unsigned int blktrace_seq __read_mostly = 1;
/*
* Send out a notify message.
*/
static unsigned int trace_note(struct blk_trace *bt, pid_t pid, int action,
const void *data, size_t len)
static void trace_note(struct blk_trace *bt, pid_t pid, int action,
const void *data, size_t len)
{
struct blk_io_trace *t;

Expand All @@ -49,8 +49,6 @@ static unsigned int trace_note(struct blk_trace *bt, pid_t pid, int action,
t->pdu_len = len;
memcpy((void *) t + sizeof(*t), data, len);
}

return blktrace_seq;
}

/*
Expand All @@ -59,9 +57,8 @@ static unsigned int trace_note(struct blk_trace *bt, pid_t pid, int action,
*/
static void trace_note_tsk(struct blk_trace *bt, struct task_struct *tsk)
{
tsk->btrace_seq = trace_note(bt, tsk->pid,
BLK_TN_PROCESS,
tsk->comm, sizeof(tsk->comm));
tsk->btrace_seq = blktrace_seq;
trace_note(bt, tsk->pid, BLK_TN_PROCESS, tsk->comm, sizeof(tsk->comm));
}

static void trace_note_time(struct blk_trace *bt)
Expand Down

0 comments on commit a863055

Please sign in to comment.