Skip to content

Commit

Permalink
update cadvisor version in test
Browse files Browse the repository at this point in the history
update NodePrePullImageList

fix conflicts

fix conflicts

remove script

add cadvisor as dependency

address comments
  • Loading branch information
Jiaming Xu committed Jan 7, 2022
1 parent ed3d9f7 commit d6d63b4
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
9 changes: 9 additions & 0 deletions build/dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -226,3 +226,12 @@ dependencies:
refPaths:
- path: test/utils/image/manifest.go
match: configs\[CheckMetadataConcealment\] = Config{list\.PromoterE2eRegistry, "metadata-concealment", "\d+\.\d+"}

# cadvisor
- name: "gcr.io/cadvisor/cadvisor: dependents"
version: "v0.43.0"
refPaths:
- path: test/e2e_node/resource_collector.go
match: gcr.io\/cadvisor\/cadvisor:v\d+\.\d+\.\d+
- path: test/e2e_node/image_list.go
mathc: gcr.io\/cadvisor\/cadvisor:v\d+\.\d+\.\d+
2 changes: 1 addition & 1 deletion test/e2e_node/image_list.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const (
// before test running so that the image pulling won't fail in actual test.
var NodePrePullImageList = sets.NewString(
imageutils.GetE2EImage(imageutils.Agnhost),
"google/cadvisor:latest",
"gcr.io/cadvisor/cadvisor:v0.43.0",
"k8s.gcr.io/stress:v1",
busyboxImage,
"k8s.gcr.io/busybox@sha256:4bdd623e848417d96127e16037743f0cd8b528c026e9175e22a84f639eca58ff",
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_node/resource_collector.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ import (

const (
// resource monitoring
cadvisorImageName = "google/cadvisor:latest"
cadvisorImageName = "gcr.io/cadvisor/cadvisor:v0.43.0"
cadvisorPodName = "cadvisor"
cadvisorPort = 8090
// housekeeping interval of Cadvisor (second)
Expand Down

0 comments on commit d6d63b4

Please sign in to comment.