Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makie plotting method, add recipe for Plots.jl, example + documentation tweaks #56

Merged
merged 6 commits into from
Apr 16, 2023

Conversation

jbisits
Copy link
Owner

@jbisits jbisits commented Apr 16, 2023

Closes #51

jbisits added 6 commits April 16, 2023 19:47
CI will take a small hit but I do not think these functions need testing. Plus more docstrings
Part of StatsBase so should have option here
@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #56 (b3f114b) into main (33512fa) will decrease coverage by 2.18%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   93.89%   91.72%   -2.18%     
==========================================
  Files           2        2              
  Lines         295      302       +7     
==========================================
  Hits          277      277              
- Misses         18       25       +7     
Impacted Files Coverage Δ
src/oceanvariableconversions.jl 100.00% <ø> (ø)
src/oceanvariabledistributions.jl 86.11% <70.37%> (-3.49%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jbisits
Copy link
Owner Author

jbisits commented Apr 16, 2023

The codecov decrease is just due to the plotting recipe (which works) and the function to convert zeros to NaN for convert_arguments, which also looks to be working so I can live with the small loss of coverage and write a test (not for the recipe) if need be.

@jbisits jbisits merged commit d58c961 into main Apr 16, 2023
@jbisits jbisits deleted the joey-plotting branch April 16, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imporve covert_arguments method
1 participant