Fix CA1841

jbk-xiao · Apr 16, 2023 · 07fb5e8 · 07fb5e8
1 parent 8fe82ed
commit 07fb5e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.editorconfig b/.editorconfig
@@ -741,6 +741,9 @@ dotnet_diagnostic.CA1839.severity = warning
 # Use Environment.CurrentManagedThreadId instead of Thread.CurrentThread.ManagedThreadId.
 dotnet_diagnostic.CA1840.severity = warning
 
+# Prefer Dictionary Contains methods.
+dotnet_diagnostic.CA1841.severity = warning
+
 # Do not use 'WhenAll' with a single task.
 dotnet_diagnostic.CA1842.severity = warning
 

diff --git a/OpenRA.Mods.Common/Lint/CheckVoiceReferences.cs b/OpenRA.Mods.Common/Lint/CheckVoiceReferences.cs
@@ -66,7 +66,7 @@ void CheckVoices(ActorInfo actorInfo, Action<string> emitError, Ruleset rules, s
 						if (string.IsNullOrEmpty(voice))
 							continue;
 
-						if (!soundInfo.Voices.Keys.Contains(voice))
+						if (!soundInfo.Voices.ContainsKey(voice))
 							emitError($"Actor {actorInfo.Name} using voice set {voiceSet} does not define {voice} voice required by {traitInfo}.");
 					}
 				}