Make orientation caching in HitShape readonly

HitShape Requires<BodyOrientation> anyway.
jbk-xiao · Jul 2, 2021 · feba9f2 · feba9f2
1 parent 6d55161
commit feba9f2
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/OpenRA.Mods.Common/Traits/HitShape.cs b/OpenRA.Mods.Common/Traits/HitShape.cs
@@ -69,16 +69,18 @@ static object LoadShape(MiniYaml yaml)
 
 	public class HitShape : ConditionalTrait<HitShapeInfo>, ITargetablePositions
 	{
-		BodyOrientation orientation;
+		readonly BodyOrientation orientation;
 		ITargetableCells targetableCells;
 		Turreted turret;
 
 		public HitShape(Actor self, HitShapeInfo info)
-			: base(info) { }
+			: base(info)
+		{
+			orientation = self.Trait<BodyOrientation>();
+		}
 
 		protected override void Created(Actor self)
 		{
-			orientation = self.Trait<BodyOrientation>();
 			targetableCells = self.TraitOrDefault<ITargetableCells>();
 			turret = self.TraitsImplementing<Turreted>().FirstOrDefault(t => t.Name == Info.Turret);