Skip to content

Commit

Permalink
Skip install on tox pylint (home-assistant#39260)
Browse files Browse the repository at this point in the history
We're not operating on the installed package anyway, and necessary
dependencies are handled with tox deps.

As a nice bonus side effect, doing this sidesteps breakage caused by
pip's (up to 20.2.2 at least) behavior of prepending site-packages to
sys.path in certain cases, which in turn results in failures e.g. if a
version of typing that is incompatible with the (now overridden)
stdlib is installed there. And that combined with also pip's behavior
of installing a default build system consisting of setuptools and
wheel under the hood when it sees our pyproject.toml without a
build-system defined would provoke the breakage before we have a
chance to uninstall typing. (There are ways around this too, but
skipping the install makes the issue moot at least with our current
dependency set.)
  • Loading branch information
scop authored Aug 27, 2020
1 parent 98993d8 commit 27f3c0a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ deps =
-r{toxinidir}/requirements_test_all.txt

[testenv:pylint]
skip_install = True
ignore_errors = True
deps =
-r{toxinidir}/requirements_all.txt
Expand Down

0 comments on commit 27f3c0a

Please sign in to comment.