Skip to content

Commit

Permalink
media: v4l2-common.h: kerneldoc: correctly format return values
Browse files Browse the repository at this point in the history
Building the kerneldoc resulted in two errors:

Documentation/media/driver-api/v4l2-common:6: ./include/media/v4l2-common.h:566: ERROR: Unexpected indentation.
Documentation/media/driver-api/v4l2-common:6: ./include/media/v4l2-common.h:567: WARNING: Block quote ends without a blank line; unexpected unindent.

Format v4l2_link_freq_to_bitmap according to the kerneldoc standard.
The v4l2_fill_pixfmt_mp function also had incorrect return value
formatting, although that didn't report an error/warning, but it looked
ugly in the generated documentation. So fix that one as well.

Signed-off-by: Hans Verkuil <[email protected]>
Fixes: a68e88e ("media: v4l: Add a helper for setting up link-frequencies control")
Acked-by: Sakari Ailus <[email protected]>
  • Loading branch information
Hans Verkuil committed Feb 5, 2024
1 parent 8f94b49 commit 83d48b5
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions include/media/v4l2-common.h
Original file line number Diff line number Diff line change
Expand Up @@ -536,9 +536,10 @@ int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat,
* V4L2_CID_LINK_FREQ control implemented by the transmitter, or value
* calculated based on the V4L2_CID_PIXEL_RATE implemented by the transmitter.
*
* Returns link frequency on success, otherwise a negative error code:
* -ENOENT: Link frequency or pixel rate control not found
* -EINVAL: Invalid link frequency value
* Return:
* * >0: Link frequency
* * %-ENOENT: Link frequency or pixel rate control not found
* * %-EINVAL: Invalid link frequency value
*/
s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul,
unsigned int div);
Expand All @@ -560,11 +561,11 @@ u32 v4l2_fraction_to_interval(u32 numerator, u32 denominator);
* system firmware and sets the corresponding bits in @bitmap (after first
* zeroing it).
*
* Return values:
* 0: Success
* -ENOENT: No match found between driver-supported link frequencies and
* those available in firmware.
* -ENODATA: No link frequencies were specified in firmware.
* Return:
* * %0: Success
* * %-ENOENT: No match found between driver-supported link frequencies and
* those available in firmware.
* * %-ENODATA: No link frequencies were specified in firmware.
*/
int v4l2_link_freq_to_bitmap(struct device *dev, const u64 *fw_link_freqs,
unsigned int num_of_fw_link_freqs,
Expand Down

0 comments on commit 83d48b5

Please sign in to comment.