Skip to content

Commit

Permalink
Be consistent with window checks
Browse files Browse the repository at this point in the history
Q's implementation compares typeof window to the string 'undefined', for consistency doing the same in the tests.
  • Loading branch information
kahnvex committed Apr 27, 2015
1 parent 3575854 commit 8cd3005
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec/q-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2506,7 +2506,7 @@ describe("browser support", function () {
Q.noConflict();

// In this context the original value of Q is undefined.
if(typeof window === 'object') {
if(typeof window !== 'undefined') {
expect(Q).toEqual(undefined);
}
});
Expand Down

0 comments on commit 8cd3005

Please sign in to comment.