Prevent memory leaks

jbunton-atlassian · Jun 25, 2012 · d920b30 · d920b30
1 parent 0428c15
commit d920b30
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/q.js b/q.js
@@ -1334,10 +1334,14 @@ function end(promise) {
 exports.timeout = timeout;
 function timeout(promise, ms) {
     var deferred = defer();
-    when(promise, deferred.resolve, deferred.reject);
-    setTimeout(function () {
-        deferred.reject(new Error("Timed out after " + ms + "ms"));
+    var timeoutId = setTimeout(function () {
+        deferred.reject(new Error("Timed out after " + ms + " ms"));
     }, ms);
+
+    when(promise, function (value) {
+        clearTimeout(timeoutId);
+        deferred.resolve(value);
+    }, deferred.reject);
     return deferred.promise;
 }