Merge pull request hyperledger-web3j#493 from e-Contract/transaction-…

…receipt-isStatusOK isStatusOK on TransactionReceipt
jcbombardelli · Apr 20, 2018 · b86ace8 · b86ace8
2 parents 3f3bc56 + 9f71630
commit b86ace8
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/core/src/main/java/org/web3j/protocol/core/methods/response/TransactionReceipt.java b/core/src/main/java/org/web3j/protocol/core/methods/response/TransactionReceipt.java
@@ -136,6 +136,14 @@ public void setStatus(String status) {
         this.status = status;
     }
 
+    public boolean isStatusOK() {
+        if (null == status) {
+            return true;
+        }
+        BigInteger statusQuantity = Numeric.decodeQuantity(status);
+        return BigInteger.ONE.equals(statusQuantity);
+    }
+
     public String getFrom() {
         return from;
     }

diff --git a/core/src/test/java/org/web3j/protocol/core/ResponseTest.java b/core/src/test/java/org/web3j/protocol/core/ResponseTest.java
@@ -1061,6 +1061,20 @@ public void testeEthGetTransactionReceiptAfterByzantium() {
                 equalTo(transactionReceipt));
     }
 
+    @Test
+    public void testTransactionReceiptIsStatusOK() {
+        TransactionReceipt transactionReceipt = new TransactionReceipt();
+        transactionReceipt.setStatus("0x1");
+        assertThat(transactionReceipt.isStatusOK(), equalTo(true));
+
+        TransactionReceipt transactionReceiptNoStatus = new TransactionReceipt();
+        assertThat(transactionReceiptNoStatus.isStatusOK(), equalTo(true));
+
+        TransactionReceipt transactionReceiptZeroStatus = new TransactionReceipt();
+        transactionReceiptZeroStatus.setStatus("0x0");
+        assertThat(transactionReceiptZeroStatus.isStatusOK(), equalTo(false));
+    }
+
     @Test
     public void testEthGetCompilers() {
         buildResponse(