ARM64 support #19
Merged
ARM64 support #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add windows arm64 support
# Conflicts: # pkg/edge/ICoreWebView2Controller.go
|
Awesome. I don’t currently have an ARM64 Windows machine to test on, but the diff looks trivially good to me. (I would bet winloader is broken on ARM64 though :) |
|
winloader worked fine on my ARM64 VM 😄 |
|
Thanks for merging. |
|
No problem, thanks for contributing. Winloader working on ARM is a pleasant surprise. It’s supposed to, but was never tested. I was expecting to have forgotten an ICache invalidation or similar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the amazing work of @stffabi, we can now support ARM64!