forked from llvm-mirror/llvm
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
reintroduce support for Mips "small" section handling. This is
implemented somewhat differently than before, but it should have the same functionality and the previous testcase passes again. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@78900 91177308-0d34-0410-b5e6-96231b3b80d8
- Loading branch information
Showing
8 changed files
with
172 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| //===-- MipsTargetObjectFile.cpp - Mips object files ----------------------===// | ||
| // | ||
| // The LLVM Compiler Infrastructure | ||
| // | ||
| // This file is distributed under the University of Illinois Open Source | ||
| // License. See LICENSE.TXT for details. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "MipsTargetObjectFile.h" | ||
| #include "llvm/DerivedTypes.h" | ||
| #include "llvm/GlobalVariable.h" | ||
| #include "llvm/MC/MCSectionELF.h" | ||
| #include "llvm/Target/TargetData.h" | ||
| #include "llvm/Target/TargetMachine.h" | ||
| #include "llvm/Support/CommandLine.h" | ||
| using namespace llvm; | ||
|
|
||
| static cl::opt<unsigned> | ||
| SSThreshold("mips-ssection-threshold", cl::Hidden, | ||
| cl::desc("Small data and bss section threshold size (default=8)"), | ||
| cl::init(8)); | ||
|
|
||
| void MipsTargetObjectFile::Initialize(MCContext &Ctx, const TargetMachine &TM){ | ||
| TargetLoweringObjectFileELF::Initialize(Ctx, TM); | ||
|
|
||
| SmallDataSection = | ||
| getELFSection(".sdata", MCSectionELF::SHT_PROGBITS, | ||
| MCSectionELF::SHF_WRITE | MCSectionELF::SHF_ALLOC, | ||
| SectionKind::getDataRel()); | ||
|
|
||
| SmallBSSSection = | ||
| getELFSection(".sbss", MCSectionELF::SHT_NOBITS, | ||
| MCSectionELF::SHF_WRITE | MCSectionELF::SHF_ALLOC, | ||
| SectionKind::getBSS()); | ||
|
|
||
| } | ||
|
|
||
| // A address must be loaded from a small section if its size is less than the | ||
| // small section size threshold. Data in this section must be addressed using | ||
| // gp_rel operator. | ||
| static bool IsInSmallSection(uint64_t Size) { | ||
| return Size > 0 && Size <= SSThreshold; | ||
| } | ||
|
|
||
| bool MipsTargetObjectFile::IsGlobalInSmallSection(const GlobalValue *GV, | ||
| const TargetMachine &TM) const { | ||
| if (GV->isDeclaration() || GV->hasAvailableExternallyLinkage()) | ||
| return false; | ||
|
|
||
| return IsGlobalInSmallSection(GV, TM, getKindForGlobal(GV, TM)); | ||
| } | ||
|
|
||
| /// IsGlobalInSmallSection - Return true if this global address should be | ||
| /// placed into small data/bss section. | ||
| bool MipsTargetObjectFile:: | ||
| IsGlobalInSmallSection(const GlobalValue *GV, const TargetMachine &TM, | ||
| SectionKind Kind) const { | ||
| // Only global variables, not functions. | ||
| const GlobalVariable *GVA = dyn_cast<GlobalVariable>(GV); | ||
| if (!GVA) | ||
| return false; | ||
|
|
||
| // We can only do this for datarel or BSS objects for now. | ||
| if (!Kind.isBSS() && !Kind.isDataRel()) | ||
| return false; | ||
|
|
||
| // If this is a internal constant string, there is a special | ||
| // section for it, but not in small data/bss. | ||
| if (Kind.isMergeable1ByteCString()) | ||
| return false; | ||
|
|
||
| const Type *Ty = GV->getType()->getElementType(); | ||
| return IsInSmallSection(TM.getTargetData()->getTypeAllocSize(Ty)); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| const MCSection *MipsTargetObjectFile:: | ||
| SelectSectionForGlobal(const GlobalValue *GV, SectionKind Kind, | ||
| Mangler *Mang, const TargetMachine &TM) const { | ||
| // TODO: Could also support "weak" symbols as well with ".gnu.linkonce.s.*" | ||
| // sections? | ||
|
|
||
| // Handle Small Section classification here. | ||
| if (Kind.isBSS() && IsGlobalInSmallSection(GV, TM, Kind)) | ||
| return SmallBSSSection; | ||
| if (Kind.isDataNoRel() && IsGlobalInSmallSection(GV, TM, Kind)) | ||
| return SmallDataSection; | ||
|
|
||
| // Otherwise, we work the same as ELF. | ||
| return TargetLoweringObjectFileELF::SelectSectionForGlobal(GV, Kind, Mang,TM); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| //===-- llvm/Target/MipsTargetObjectFile.h - Mips Object Info ---*- C++ -*-===// | ||
| // | ||
| // The LLVM Compiler Infrastructure | ||
| // | ||
| // This file is distributed under the University of Illinois Open Source | ||
| // License. See LICENSE.TXT for details. | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_TARGET_MIPS_TARGETOBJECTFILE_H | ||
| #define LLVM_TARGET_MIPS_TARGETOBJECTFILE_H | ||
|
|
||
| #include "llvm/Target/TargetLoweringObjectFile.h" | ||
|
|
||
| namespace llvm { | ||
|
|
||
| class MipsTargetObjectFile : public TargetLoweringObjectFileELF { | ||
| const MCSection *SmallDataSection; | ||
| const MCSection *SmallBSSSection; | ||
| public: | ||
|
|
||
| void Initialize(MCContext &Ctx, const TargetMachine &TM); | ||
|
|
||
|
|
||
| /// IsGlobalInSmallSection - Return true if this global address should be | ||
| /// placed into small data/bss section. | ||
| bool IsGlobalInSmallSection(const GlobalValue *GV, | ||
| const TargetMachine &TM, SectionKind Kind)const; | ||
| bool IsGlobalInSmallSection(const GlobalValue *GV, | ||
| const TargetMachine &TM) const; | ||
|
|
||
| const MCSection *SelectSectionForGlobal(const GlobalValue *GV, | ||
| SectionKind Kind, | ||
| Mangler *Mang, | ||
| const TargetMachine &TM) const; | ||
|
|
||
| // TODO: Classify globals as mips wishes. | ||
| }; | ||
| } // end namespace llvm | ||
|
|
||
| #endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| ; RUN: llvm-as < %s | llc -mips-ssection-threshold=8 -march=mips -f -o %t0 | ||
| ; RUN: llvm-as < %s | llc -mips-ssection-threshold=0 -march=mips -f -o %t1 | ||
| ; RUN: grep {sdata} %t0 | count 1 | ||
| ; RUN: grep {sbss} %t0 | count 1 | ||
| ; RUN: grep {gp_rel} %t0 | count 2 | ||
| ; RUN: not grep {sdata} %t1 | ||
| ; RUN: not grep {sbss} %t1 | ||
| ; RUN: not grep {gp_rel} %t1 | ||
| ; RUN: grep {\%hi} %t1 | count 2 | ||
| ; RUN: grep {\%lo} %t1 | count 2 | ||
|
|
||
| target datalayout = "e-p:32:32:32-i1:8:8-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64" | ||
| target triple = "mipsallegrexel-psp-elf" | ||
|
|
||
| %struct.anon = type { i32, i32 } | ||
| @s0 = global [8 x i8] c"AAAAAAA\00", align 4 | ||
| @foo = global %struct.anon { i32 2, i32 3 } | ||
| @bar = global %struct.anon zeroinitializer | ||
|
|
||
| define i8* @A0() nounwind { | ||
| entry: | ||
| ret i8* getelementptr ([8 x i8]* @s0, i32 0, i32 0) | ||
| } | ||
|
|
||
| define i32 @A1() nounwind { | ||
| entry: | ||
| load i32* getelementptr (%struct.anon* @foo, i32 0, i32 0), align 8 | ||
| load i32* getelementptr (%struct.anon* @foo, i32 0, i32 1), align 4 | ||
| add i32 %1, %0 | ||
| ret i32 %2 | ||
| } | ||
|
|