Skip to content

Commit

Permalink
Code review requested changes
Browse files Browse the repository at this point in the history
	- Removed tinting on images
	- Renamed addSmall to addMedium
  • Loading branch information
serjooo committed Oct 14, 2019
1 parent 10b6730 commit a05e916
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions Papr/Commons/Constants.swift
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,14 @@ enum Constants {

static var doneWhiteSmall: UIImage {
if #available(iOS 13.0, *) {
return UIImage(systemName: "checkmark", withConfiguration: symbolConfigurationSmall)!.withTintColor(.white)
return UIImage(systemName: "checkmark", withConfiguration: symbolConfigurationSmall)!
}
return UIImage(imageLiteralResourceName: "done")
}

static var addSmall: UIImage {
static var addMedium: UIImage {
if #available(iOS 13.0, *) {
return UIImage(systemName: "plus", withConfiguration: symbolConfigurationMedium)!.withTintColor(.white)
return UIImage(systemName: "plus", withConfiguration: symbolConfigurationMedium)!
}
return UIImage(imageLiteralResourceName: "plus")
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class AddToCollectionViewController: UIViewController, BindableType {
action: nil
)
addToCollectionBarButton = UIBarButtonItem(
image: Constants.Appearance.Icon.addSmall,
image: Constants.Appearance.Icon.addMedium,
style: .plain,
target: self,
action: nil
Expand Down

0 comments on commit a05e916

Please sign in to comment.