Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Papr crashes in iOS 12 and lower. #96

Closed
jdisho opened this issue Oct 22, 2019 · 1 comment
Closed

Papr crashes in iOS 12 and lower. #96

jdisho opened this issue Oct 22, 2019 · 1 comment
Labels

Comments

@jdisho
Copy link
Owner

jdisho commented Oct 22, 2019

Since SVG format is not supported in iOS, the app crashes when it tries to access an image with a given resource name.

static var arrowUpRight: UIImage {
    if #available(iOS 13.0, *) {
        return UIImage(systemName: "arrow.up.right", withConfiguration: symbolConfigurationMedium)!#
    }
    return UIImage(imageLiteralResourceName: "arrow.up.right") // #CRASH
}

We can solve this issue by (I would like to avoid having a dependency for this use case) by converting the SVGs into .png or supporting iOS13 and higher.

Thoughts on this @serjooo (since you closed #89) ?

(This app is not planned to be released, so supporting only the latest iOS version seems fine to me.)

@jdisho jdisho added the bug label Oct 22, 2019
@serjooo
Copy link
Contributor

serjooo commented Oct 22, 2019

I think it would be nice to support older versions of iOS. So I don't mind providing the images in PNG format and returning those images when needed, this way we avoid using a dependency as well. However, we will have duplicated resources. Also, maybe where we have set the image only by storyboard we would need to set it by code now. What do you think? @jdisho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants