Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all SVG images to PDF #97

Merged
merged 6 commits into from
Oct 27, 2019
Merged

Convert all SVG images to PDF #97

merged 6 commits into from
Oct 27, 2019

Conversation

serjooo
Copy link
Contributor

@serjooo serjooo commented Oct 26, 2019

Closes issue #96

This PR converts all SVG images added for iOS 13 to support SFSymbols to PDF. This way we can still use them as vector images. For each medium/small size and medium/regular weight an image was set in the assets accordingly.

Known issue while working on PR:

App crashes still on iOS 12.2 in the HomeViewController on line 82:

outputs.isRefreshing
.execute { [weak self] isRefreshing in
    if isRefreshing {
        self?.collectionView.scrollToItem(at: IndexPath(item: 0, section: 0), at: .top, animated: false)
        self?.collectionView.setContentOffset(CGPoint(x: 0.0, y: -(self?.refreshControl.frame.height ?? 0.0)), animated: true)
    } else {
        self?.collectionView.setContentOffset(.zero, animated: true)
    }
}
.bind(to: refreshControl.rx.isRefreshing)
.disposed(by: disposeBag)

Commenting out the isRefreshing code solves the problem as the app crashes on scrolling logic.

@jdisho jdisho merged commit b3b854b into jdisho:develop Oct 27, 2019
@jdisho
Copy link
Owner

jdisho commented Oct 27, 2019

Hah! Interesting about the crash. I will have a look 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants