apacheGH-36013: [C++] Disabling bundled OpenTelemetry with Protobuf 3…

….22+ (apache#36016) OpenTelemetry and Protobuf 3.22+ have conflicting versions of Abseil, which is causing build errors. This patch disables OpenTelemetry on macOS because Homebrew provides Protobuf 3.22+. * Closes: apache#36013 Authored-by: Benjamin Kietzman <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
jduo · Jun 16, 2023 · 41309de · 41309de
1 parent 1fb415c
commit 41309de
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
@@ -162,7 +162,9 @@ jobs:
       ARROW_WITH_BROTLI: ON
       ARROW_WITH_BZ2: ON
       ARROW_WITH_LZ4: ON
-      ARROW_WITH_OPENTELEMETRY: ON
+      # GH-36013 disabling opentelemetry here because we can't
+      # get the patched version from conda
+      # ARROW_WITH_OPENTELEMETRY: ON
       ARROW_WITH_SNAPPY: ON
       ARROW_WITH_ZLIB: ON
       ARROW_WITH_ZSTD: ON

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -4511,6 +4511,10 @@ endif()
 
 macro(build_opentelemetry)
   message(STATUS "Building OpenTelemetry from source")
+  if(Protobuf_VERSION VERSION_GREATER_EQUAL 3.22)
+    message(FATAL_ERROR "GH-36013: Can't use bundled OpenTelemetry with Protobuf 3.22 or later. "
+                        "Protobuf is version ${Protobuf_VERSION}")
+  endif()
 
   set(OPENTELEMETRY_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/opentelemetry_ep-install")
   set(OPENTELEMETRY_INCLUDE_DIR "${OPENTELEMETRY_PREFIX}/include")